From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Victor Seva <linuxmaniac@torreviejawireless.org>,
pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH storage v5] fix #957: iscsi: improve iscsi_test_portal logic
Date: Tue, 25 Mar 2025 19:35:43 +0100 [thread overview]
Message-ID: <e617451c-a98e-4be7-b5ab-91978c4ea671@proxmox.com> (raw)
In-Reply-To: <20250320142319.20411-2-linuxmaniac@torreviejawireless.org>
Am 20.03.25 um 15:23 schrieb Victor Seva:
> Check if there is already a logged session present and
> fall back to previous TCP check port connection.
>
> pvestatd is calling check_connection every 10 seconds.
> This check produces a lot of noise at the iscsi server logging.
>
> Signed-off-by: Victor Seva <linuxmaniac@torreviejawireless.org>
> ---
>
> changes since v4:
>
> * rework commit message wording and subject in proper format
>
> * iscsi_test_session():
> use [0-9] instead of \d
> simplify return logic checking $state is defined too
>
> * iscsi_test_portal():
> fallback to TCP check connection if session is not LOGGED_IN
>
> * iscsi_discovery():
> rename $target to $target_in to avoid variable shadowing
>
> src/PVE/Storage.pm | 2 +-
> src/PVE/Storage/ISCSIPlugin.pm | 39 ++++++++++++++++++++++++++--------
> 2 files changed, 31 insertions(+), 10 deletions(-)
>
>
applied with Mira's and Friedrich's R-b and T-b trailers, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
parent reply other threads:[~2025-03-25 18:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250320142319.20411-2-linuxmaniac@torreviejawireless.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e617451c-a98e-4be7-b5ab-91978c4ea671@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=linuxmaniac@torreviejawireless.org \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal