From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Dominic Jäger" <d.jaeger@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: add netdevice: fix #3203: Use OS default model
Date: Tue, 12 Jan 2021 11:49:28 +0100 [thread overview]
Message-ID: <e5da1ef5-c059-b01b-3b02-1e9db3d4c28f@proxmox.com> (raw)
In-Reply-To: <20210107100438.73753-1-d.jaeger@proxmox.com>
On 07.01.21 11:04, Dominic Jäger wrote:
> In the VM create wizard we automatically set e1000 for Windows and virtio for
> Linux. We should also do this when adding a network device in the hardware
> view.
>
> OSDefaults.generic.networkCard (=e1000) is always available. Hence, leave this
> as default value for the field and then try to get the ostype via API and
> overwrite the default e1000.
>
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
> www/manager6/qemu/NetworkEdit.js | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>
applied, thanks that bothered me already a few times!
Theoretically we could make a heuristic to check if there's already a virtio
network device in the config for windows OS-types, and then also default to
that.
prev parent reply other threads:[~2021-01-12 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 10:04 [pve-devel] " Dominic Jäger
2021-01-12 10:49 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5da1ef5-c059-b01b-3b02-1e9db3d4c28f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox