From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 2/2] increase timeout for QMP block_resize
Date: Tue, 30 Mar 2021 18:57:28 +0200 [thread overview]
Message-ID: <e5b19455-8d63-a104-b1dc-994d888cfd5b@proxmox.com> (raw)
In-Reply-To: <20210330155952.16389-2-s.reiter@proxmox.com>
On 30.03.21 17:59, Stefan Reiter wrote:
> In testing this usually completes almost immediately, but in theory this
> is a storage/IO operation and as such can take a bit to finish. It's
> certainly not unthinkable that it might take longer than the default *3
> seconds* we've given it so far. Make it a minute.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Optional for the fix, but seems like a good idea.
>
> PVE/QemuServer.pm | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 1c0b5c2..f9379f6 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4291,8 +4291,13 @@ sub qemu_block_resize {
> my $padding = (1024 - $size % 1024) % 1024;
> $size = $size + $padding;
>
> - mon_cmd($vmid, "block_resize", device => $deviceid, size => int($size));
> -
> + mon_cmd(
> + $vmid,
> + "block_resize",
> + device => $deviceid,
> + size => int($size),
> + timeout => 60,
> + );
> }
>
> sub qemu_volume_snapshot {
>
next prev parent reply other threads:[~2021-03-30 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 15:59 [pve-devel] [PATCH pve-qemu 1/2] add upstream fixes for qmp_block_resize Stefan Reiter
2021-03-30 15:59 ` [pve-devel] [PATCH qemu-server 2/2] increase timeout for QMP block_resize Stefan Reiter
2021-03-30 16:57 ` Thomas Lamprecht [this message]
2021-03-30 16:57 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-30 16:57 ` [pve-devel] applied: [PATCH pve-qemu 1/2] add upstream fixes for qmp_block_resize Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5b19455-8d63-a104-b1dc-994d888cfd5b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox