From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] fix #5543: pci: don't use pci devices when starting templates
Date: Wed, 19 Jun 2024 10:28:48 +0200 [thread overview]
Message-ID: <e55b66ec-30b4-4951-84ab-8f3fa85789cf@proxmox.com> (raw)
In-Reply-To: <58242816-e1b8-4d53-86d3-f07f250606fe@proxmox.com>
On 6/19/24 10:17, Fiona Ebner wrote:
> Am 19.06.24 um 10:14 schrieb Fiona Ebner:
>> I'd be in favor of fixing this together with
>> https://bugzilla.proxmox.com/show_bug.cgi?id=3352
>> and use a minimal QEMU commandline that only attaches the block devices
>> and nothing else. I guess the addition for the PCI cleanup is still
>> needed, but getting the minimal commandline is probably best done as a
>> new helper. What do you think?
>>
>
> Another way would be to reduce the config we pass to config_to_command
> to only the block devices and 1 CPU, etc.. Maybe that's more
> straight-forward than a new helper.
yeah, some combined fix for that would be good, did not have that bug on my
radar.
I agree that 'minifying' the config is probably the way to go here,
but as you said, the cleanup should also be touched so it does not
throw warnings for not available devices etc.
I think we could have a set of keys as a whitelist to copy, and leave all
others default, i think for starters we should whitelist:
* all disk configs (excl. cdroms)
* the kvm setting
* anything else ?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-06-19 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 6:37 Dominik Csapak
2024-06-19 8:14 ` Fiona Ebner
2024-06-19 8:17 ` Fiona Ebner
2024-06-19 8:28 ` Dominik Csapak [this message]
2024-06-19 8:55 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e55b66ec-30b4-4951-84ab-8f3fa85789cf@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox