From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 manager 1/2] HDEdit: check iothread by default and move it from advanced section
Date: Wed, 18 May 2022 11:40:02 +0200 [thread overview]
Message-ID: <e53f8442-5e88-7876-1268-179a8e05f17e@proxmox.com> (raw)
In-Reply-To: <20220512092416.137095-1-m.heiserer@proxmox.com>
Am 12.05.22 um 11:24 schrieb Matthias Heiserer:
> Existing disks are not changed by this.
> Especially in benchmarks, iothreads significantly improve IO performance.
>
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> Changes from v2:
> * also check iothread when adding a disk to an existing VM and
> scsi single
> * use bind instead of hardcoded true
This feels like to much automagic to me, because changes to the checkbox
(even if checkbox is for a virtio disk) will change the controller type
and vice versa. This also makes it impossible to only set iothread on
certain disks or use the "Virtio SCSI single" controller type without
setting iothread.
Is it possible to instead have the checkbox be invalid with an
appropriate error for the user when it's a bad configuration?
next prev parent reply other threads:[~2022-05-18 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 9:24 Matthias Heiserer
2022-05-12 9:24 ` [pve-devel] [PATCH v3 qemu-server 1/2] bump pve-common Matthias Heiserer
2022-05-12 9:24 ` [pve-devel] [PATCH v3 manager 2/2] OS defaults: use SCSI single as default controller Matthias Heiserer
2022-05-12 9:24 ` [pve-devel] [PATCH v3 qemu-server 2/2] Warn in GUI for unlikely iothread config - fixes #3890 Matthias Heiserer
2022-05-18 9:44 ` Fabian Ebner
2022-05-18 9:40 ` Fabian Ebner [this message]
2022-05-19 13:35 ` [pve-devel] [PATCH v3 manager 1/2] HDEdit: check iothread by default and move it from advanced section Matthias Heiserer
2022-05-20 6:52 ` Fabian Ebner
2022-05-27 11:53 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e53f8442-5e88-7876-1268-179a8e05f17e@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox