public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager v2 0/2] ui: tasks: add button to open task
Date: Mon, 18 Nov 2024 11:49:10 +0100	[thread overview]
Message-ID: <e53a2215-8447-496d-93fc-a0d9df9d02af@proxmox.com> (raw)
In-Reply-To: <20241111155043.369360-1-a.lauterer@proxmox.com>

sent a v3 with ideas and feedback received

https://lore.proxmox.com/pve-devel/20241118104530.91798-1-a.lauterer@proxmox.com/T/#t

On  2024-11-11  16:50, Aaron Lauterer wrote:
> the first patch adds a new action column to open the task.
> 
> this will hopefully make it clearer for (new) users that a task can be
> opened.
> 
> The second, opional, patch, adapts the code to the more current way of
> opening a new window.
> 
> changes:
> v1: implement code improvement in patch 1/2
> 
> Aaron Lauterer (2):
>    ui: tasks: add actioncolumn to open task
>    ui: tasks: use autoshow instead of win.show
> 
>   www/manager6/dc/Tasks.js | 23 +++++++++++++++++++++--
>   1 file changed, 21 insertions(+), 2 deletions(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2024-11-18 10:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 15:50 Aaron Lauterer
2024-11-11 15:50 ` [pve-devel] [PATCH manager v2 1/2] ui: tasks: add actioncolumn " Aaron Lauterer
2024-11-16 16:04   ` Thomas Lamprecht
2024-11-11 15:50 ` [pve-devel] [PATCH manager v2 2/2] ui: tasks: use autoshow instead of win.show Aaron Lauterer
2024-11-16 15:58   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-18 10:49 ` Aaron Lauterer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e53a2215-8447-496d-93fc-a0d9df9d02af@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal