From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, c.ebner@proxmox.com
Subject: Re: [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter
Date: Thu, 5 Jan 2023 14:51:07 +0100 [thread overview]
Message-ID: <e48b11cf-9ec2-1867-35ac-191ec8a855fc@proxmox.com> (raw)
In-Reply-To: <20230105091804.156599-2-c.ebner@proxmox.com>
Just two refreshers about style ;)
Am 05.01.23 um 10:18 schrieb Christian Ebner:
> The optional unix epoch timestamps parameters `since` and `until` are introduced in order to filter
> firewall logs files.
>
> Since the `dump_logfile` function is used in multiple places, not neccessarily following the firewall
> log output format, a specialized function `dump_fw_logfile` is introduced in the PVE::Tools,
> with fallback to the previous `dump_logfile` function if none of the parameters is present.
>
> This patch depends on the corresponding patch in the pve-common repository.
>
Style nit: lines in the commit message should be <= 70 characters [0]
> @@ -197,7 +209,8 @@ __PACKAGE__->register_method({
> my $user = $rpcenv->get_user();
> my $node = $param->{node};
>
> - my ($count, $lines) = PVE::Tools::dump_logfile("/var/log/pve-firewall.log", $param->{start}, $param->{limit});
> + my($count, $lines) = PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log",
> + $param->{start}, $param->{limit}, undef, $param->{since}, $param->{until});
Style nit: please use 1 line for each parameter if it gets too long [1]
> @@ -201,9 +213,9 @@ sub register_handlers {
> my $user = $rpcenv->get_user();
> my $vmid = $param->{vmid};
>
> - my ($count, $lines) = PVE::Tools::dump_logfile("/var/log/pve-firewall.log",
> - $param->{start}, $param->{limit},
> - "^$vmid ");
> + my ($count, $lines) = PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log",
> + $param->{start}, $param->{limit}, "^$vmid ", $param->{since},
> + $param->{until});
Same here
[0]:
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
[1]: https://pve.proxmox.com/wiki/Perl_Style_Guide#Wrapping_Arguments
next prev parent reply other threads:[~2023-01-05 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 9:18 [pve-devel] [RFC common 0/1] Optional parameters `since` and `until` for firewall log filtering Christian Ebner
2023-01-05 9:18 ` [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter Christian Ebner
2023-01-05 13:51 ` Fiona Ebner [this message]
2023-01-05 13:59 ` Thomas Lamprecht
2023-01-05 14:27 ` Christian Ebner
2023-01-05 9:18 ` [pve-devel] [RFC common 1/1] tools: Add specialized `dump_fw_logfile` for `since` and `until` filtering of firewall logs Christian Ebner
2023-01-05 13:25 ` Wolfgang Bumiller
2023-01-05 14:25 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48b11cf-9ec2-1867-35ac-191ec8a855fc@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox