From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] Diskmanage: check for extended partitions
Date: Tue, 3 May 2022 13:41:18 +0200 [thread overview]
Message-ID: <e3d57482-3642-e749-c61f-39b509dba987@proxmox.com> (raw)
In-Reply-To: <20220503133915.3eb8d77a@rosa.proxmox.com>
On 5/3/22 13:39, Stoiko Ivanov wrote:
> On Tue, 3 May 2022 13:08:47 +0200
> Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>> those would not get assinged a usage and thus appear in the list
>> when we want to select a partition (e.g. for creating a zpool)
>>
>> since we cannot do anything with such a partition, return the usage
>> 'Extended Partition' for these.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> PVE/Diskmanage.pm | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm
>> index d67cc6b..f693d00 100644
>> --- a/PVE/Diskmanage.pm
>> +++ b/PVE/Diskmanage.pm
>> @@ -647,6 +647,8 @@ sub get_disks {
>> if $parttype eq 'c12a7328-f81f-11d2-ba4b-00a0c93ec93b';
>> return 'ZFS reserved'
>> if $parttype eq '6a945a3b-1dd2-11b2-99a6-080020736631';
>> + return 'Extended Partition'
>> + if $parttype eq '0x5';
> This looks like a MBR partitiontype (both the length and the concept of
> extended partition seem MBR-related) - Do we want to support MBR disks?
> (we do not in the installer and when initializing a new disk)
> Any pointer to where this could be needed?
>
> Really meant as an expression of my confusion - am fine if we want to
> support this and the patch LGTM.
>
i mean we don't have to, i just ran into that when installing
on top of debian10 -> pve6 -> pve7
so it might not be that useful...
prev parent reply other threads:[~2022-05-03 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 11:08 Dominik Csapak
2022-05-03 11:39 ` Stoiko Ivanov
2022-05-03 11:41 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3d57482-3642-e749-c61f-39b509dba987@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox