public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Daniel Tschlatscher <d.tschlatscher@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager v2] fix #3994: Options menu entry in the System menu
Date: Fri, 13 May 2022 10:00:37 +0200	[thread overview]
Message-ID: <e3b72072-42d8-1937-9884-14d1de18c3c2@proxmox.com> (raw)
In-Reply-To: <56094244-2673-e153-7945-2063767cd189@proxmox.com>

Am 5/13/22 um 09:55 schrieb Daniel Tschlatscher:
> On 5/12/22 17:13, Thomas Lamprecht wrote:
>> Some other points to improve:
>>
>> - setting the online help, maybe to 'proxmox_node_management' which would make
>>    it point to:
>>    https://pve.proxmox.com/pve-docs/chapter-sysadmin.html#proxmox_node_management
>>    (the chapter could maybe do good with some addition w.r.t. first start delay
> 
> This sounds to me like a suggestion to set the online help for the panel, i.e. the
> button in the top right corner. But that's already included in the patch.
> Or are you suggesting to put it somewhere else too?

None of the edit windows have it set. the top right corner is somewhat nice
sometimes but the real useful one is the one from the edit window, which is
much more visible, and especially the only one available if the window is open
as the background is masked then, having to close the window with some values
already half entered is the worst.

> 
>>
>> - It's not clear what unit the start delay has, you could mention that explicitly,
>>    simplest way to do so is adding a ' (s)' to the fieldLabel after the gettext.
> 
> The field does not display a value while displaying Default, though it explicitly states
> 'Seconds' after any value is set. I think it would become very clear to anybody then

That's too late, I need to know what I'm entering *on entering* not sometimes
later, when I already set a possible bogus value; while it hasn't that big
of an affect in this specific case it should be the general approach to UX
that the user knows what they enter, otherwise a UI is close to useless.

> what unit this setting represents.
> Still, adding ' (s)' probably wouldn't kill me either. 😉

Note that the "Default" in the grid is also wrong for unset, it should state "None".




      reply	other threads:[~2022-05-13  8:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 12:39 [pve-devel] " Daniel Tschlatscher
2022-05-11 12:27 ` Markus Frank
2022-05-12 15:13 ` [pve-devel] applied: " Thomas Lamprecht
2022-05-13  7:55   ` Daniel Tschlatscher
2022-05-13  8:00     ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3b72072-42d8-1937-9884-14d1de18c3c2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.tschlatscher@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal