From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH manager] ui: make label for mediated device types more clear
Date: Wed, 8 May 2024 17:00:32 +0200 [thread overview]
Message-ID: <e31adb71-cf72-4ccc-9c7e-4df21f32bfe4@proxmox.com> (raw)
In-Reply-To: <20240508125418.2598112-1-d.csapak@proxmox.com>
On 08/05/2024 14:54, Dominik Csapak wrote:
> 'MDev' could be interpreted as either 'Mediated Device' or 'Mapped
> Device', which can confuse users.
>
> At least one user was confused:
> https://forum.proxmox.com/threads/146586/#post-662091
>
> Fix that by writing out 'Mediated Device'.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> sending as RFC because the text is now too long for one line, which is
> bad IMHO, but I could not come up with a better text that fits, maybe
> someone else has a better idea (or we leave it as is)
>
>
> www/manager6/qemu/PCIEdit.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
> index 8cef1b10..940e017c 100644
> --- a/www/manager6/qemu/PCIEdit.js
> +++ b/www/manager6/qemu/PCIEdit.js
> @@ -262,7 +262,7 @@ Ext.define('PVE.qemu.PCIInputPanel', {
> name: 'mdev',
> reference: 'mdev',
> disabled: true,
> - fieldLabel: gettext('MDev Type'),
> + fieldLabel: gettext('Mediated Device Type'),
Alternatively you could add just a tooltip here, not a perfect solution
either but better than nothing for most users.
While it does not solve the wrapping, could we drop the "type" part, as
is this really a type of something or a selection a specific mediated
device?
One idea would be a bigger re-layout, i.e.:
move the radio groups beside each other so that they and their selection
combobox take up the first two rows, in the row below you could then place
the two checkboxes "all functions" and "primary GPU", and as bbar (above
the advanced section) you could have the mdev field with a wider label,
at the bottom it might not look that bad even if a bit asymmetric to the
other fields.
One would have to try and play around to see if that is an improvement,
if not, having a label wrap over is probably the lesser evil compared to
bad UX due to the label being a tad cryptic.
> nodename: me.nodename,
> listeners: {
> change: function(field, value) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-08 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 12:54 Dominik Csapak
2024-05-08 15:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e31adb71-cf72-4ccc-9c7e-4df21f32bfe4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox