[pve-devel] [PATCH storage] api/pvesm: alloc: allow 'vmdk' for the 'format' option

[pve-devel] [PATCH storage] api/pvesm: alloc: allow 'vmdk' for the 'format' option

[Fiona Ebner]

The API endpoint for allocating an image will automatically detect the
format from the extension for raw, qcow2 and vmdk, but it was not yet
possible to specify the format explicitly via the 'format' parameter.
This could be annoying/surprising to users. There also might be
third-party plugins that want to use vmdk, but not require a suffix in
the name. Add 'vmdk' as an allowed format to avoid these issues and
for consistency.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/API2/Storage/Content.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/Storage/Content.pm
index fe0ad4a..78f1e8f 100644
--- a/src/PVE/API2/Storage/Content.pm
+++ b/src/PVE/API2/Storage/Content.pm
@@ -180,7 +180,7 @@ __PACKAGE__->register_method ({
 	    },
 	    'format' => {
 		type => 'string',
-		enum => ['raw', 'qcow2', 'subvol'],
+		enum => ['raw', 'qcow2', 'subvol', 'vmdk'],
 		requires => 'size',
 		optional => 1,
 	    },
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] superseded: [PATCH storage] api/pvesm: alloc: allow 'vmdk' for the 'format' option

[Fiona Ebner]

superseded by:
https://lore.proxmox.com/pve-devel/20250305104923.23618-1-f.ebner@proxmox.com/T/#m4044c38541bfc2332bbfc0a7930a48ee1d4c3932

Am 07.02.25 um 13:55 schrieb Fiona Ebner:
> The API endpoint for allocating an image will automatically detect the
> format from the extension for raw, qcow2 and vmdk, but it was not yet
> possible to specify the format explicitly via the 'format' parameter.
> This could be annoying/surprising to users. There also might be
> third-party plugins that want to use vmdk, but not require a suffix in
> the name. Add 'vmdk' as an allowed format to avoid these issues and
> for consistency.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/API2/Storage/Content.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/Storage/Content.pm
> index fe0ad4a..78f1e8f 100644
> --- a/src/PVE/API2/Storage/Content.pm
> +++ b/src/PVE/API2/Storage/Content.pm
> @@ -180,7 +180,7 @@ __PACKAGE__->register_method ({
>  	    },
>  	    'format' => {
>  		type => 'string',
> -		enum => ['raw', 'qcow2', 'subvol'],
> +		enum => ['raw', 'qcow2', 'subvol', 'vmdk'],
>  		requires => 'size',
>  		optional => 1,
>  	    },



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel