From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH storage] api/pvesm: alloc: allow 'vmdk' for the 'format' option
Date: Thu, 6 Mar 2025 09:48:16 +0100 [thread overview]
Message-ID: <e244e379-6ce0-4be9-8aa0-71972279074b@proxmox.com> (raw)
In-Reply-To: <20250207125514.42668-1-f.ebner@proxmox.com>
superseded by:
https://lore.proxmox.com/pve-devel/20250305104923.23618-1-f.ebner@proxmox.com/T/#m4044c38541bfc2332bbfc0a7930a48ee1d4c3932
Am 07.02.25 um 13:55 schrieb Fiona Ebner:
> The API endpoint for allocating an image will automatically detect the
> format from the extension for raw, qcow2 and vmdk, but it was not yet
> possible to specify the format explicitly via the 'format' parameter.
> This could be annoying/surprising to users. There also might be
> third-party plugins that want to use vmdk, but not require a suffix in
> the name. Add 'vmdk' as an allowed format to avoid these issues and
> for consistency.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/API2/Storage/Content.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/Storage/Content.pm
> index fe0ad4a..78f1e8f 100644
> --- a/src/PVE/API2/Storage/Content.pm
> +++ b/src/PVE/API2/Storage/Content.pm
> @@ -180,7 +180,7 @@ __PACKAGE__->register_method ({
> },
> 'format' => {
> type => 'string',
> - enum => ['raw', 'qcow2', 'subvol'],
> + enum => ['raw', 'qcow2', 'subvol', 'vmdk'],
> requires => 'size',
> optional => 1,
> },
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-06 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 12:55 [pve-devel] " Fiona Ebner
2025-03-06 8:48 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e244e379-6ce0-4be9-8aa0-71972279074b@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal