From: Fiona Ebner <f.ebner@proxmox.com>
To: Andrei Perapiolkin <andrei.perepiolkin@open-e.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] Handling 'path' requests during VM deletion
Date: Tue, 9 Sep 2025 11:54:27 +0200 [thread overview]
Message-ID: <e1d76a4d-327a-4ce3-8930-7ba6a9960713@proxmox.com> (raw)
In-Reply-To: <472f7cfb-f105-4e71-834f-8c3352ee82df@open-e.com>
Am 08.09.25 um 10:07 PM schrieb Andrei Perapiolkin:
> I have added a bug report: https://bugzilla.proxmox.com/show_bug.cgi?
> id=6776
Thanks!
> I also decided to return an empty string ('') for volumes that do not
> exist.
>
> My reasoning is that if I return any path that might actually exist,
> some parts of the Proxmox system could try to open, read, or write to
> this "file," unintentionally creating it.
> This could corrupt the server’s file system, or consume disk space if
> the server has limited local storage — for example, when the operation
> involves cloning a multi-terabyte data block.
>
> I would like to hear your opinion regarding this conclusion.
> Is it acceptable, or should I re-evaluate it?
I don't think an image would be auto-created, except if the storage or
filesystem is doing that upon open, which would be wrong. The path is
just passed along to QEMU (or qemu-img) and those will abort if it
cannot be opened.
With returning '' you might run into other errors or warnings and since
other plugins don't do this, it's not really tested. You would be more
in line with other plugins by returning the path. Alternatively, using
"die" if the volume doesn't exist, seems a bit nicer too and would be in
line with what the related qemu_blockdev_options() method does.
Best Regards,
Fiona
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-09 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 21:34 Andrei Perapiolkin via pve-devel
2025-08-14 15:11 ` Fiona Ebner
2025-09-08 20:08 ` Andrei Perapiolkin via pve-devel
[not found] ` <472f7cfb-f105-4e71-834f-8c3352ee82df@open-e.com>
2025-09-09 9:54 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d76a4d-327a-4ce3-8930-7ba6a9960713@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=andrei.perepiolkin@open-e.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox