Re: [pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 07.04.25 um 18:27 schrieb Aaron Lauterer:
> This new property returns the configured or default display for a VM.
> 
> Instead of a flat property, we use a nested 'type' object that contains
> the actual information. This way we can add other properties that belong
> to a VM's display in the future without much hassle, to have them all in
> one place.
> Candidates to be moved into the clipboard property are for example the
> spice and clipboard property.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> first introduces with v5
> 
>  PVE/API2/Qemu.pm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 8b51c04..e11247b 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -3035,6 +3035,16 @@ __PACKAGE__->register_method({
>  		enum => ['vnc'],
>  		optional => 1,
>  	    },
> +	    display => {
> +		description => "Display settings",
> +		type => 'object',
> +		properties => {
> +		    type => {
> +			description => "Display type configured",
> +			type => 'string',
> +		    },
> +		},
> +	    },
>  	},
>      },
>      code => sub {
> @@ -3048,8 +3058,11 @@ __PACKAGE__->register_method({
>  
>  	$status->{ha} = PVE::HA::Config::get_service_status("vm:$param->{vmid}");
>  
> +	$status->{display}->{type} = 'std';
>  	if ($conf->{vga}) {
>  	    my $vga = PVE::QemuServer::parse_vga($conf->{vga});
> +	    $status->{display}->{type} = $vga->{type} if defined($vga->{type});
> +
>  	    my $spice = defined($vga->{type}) && $vga->{type} =~ /^virtio/;
>  	    $spice ||= PVE::QemuServer::vga_conf_has_spice($conf->{vga});
>  	    $status->{spice} = 1 if $spice;

Looks alright to me, but I do not want to rush this in, so a full test
would be nice, and I probably won't get around to that.
Cannot promise anything for 100% but if you get a positive code review
from Dominik and an additional T-b I might still look into this.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel