From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager
Date: Wed, 8 Jun 2022 16:39:29 +0200 [thread overview]
Message-ID: <e1a61550-8621-f620-7631-a61d0a797f8f@proxmox.com> (raw)
In-Reply-To: <20220608115428.250668-6-daniel@bowdernet.com>
On 08.06.2022 13:54, Daniel Bowder wrote:
> Signed-off-by: Daniel Bowder <daniel@bowdernet.com>
> ---
> The fifth patch adds the cpuset value to the GUI under the VM.Config.Options panel. The cpuset is set as a vtype of CPUSet so that it can be checked by the regex match in the fouth patch. This was modeled after the existing 'name' option,
typo: fouth -> fourth
Don't think you should be referencing other patches by number in the
commit message though, so the comment is a fitting location for this remark.
where the labels and textfield type have been changed.
> www/manager6/qemu/Options.js | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
> index a1def4bb..ce356130 100644
> --- a/www/manager6/qemu/Options.js
> +++ b/www/manager6/qemu/Options.js
> @@ -341,6 +341,36 @@ Ext.define('PVE.qemu.Options', {
> hookscript: {
> header: gettext('Hookscript'),
> },
> + cpuset: {
> + required: false,
> + header: gettext('CPU Set'),
> + defaultValue: "",
> + editor: caps.vms['VM.Config.Options'] ? {
> + xtype: 'proxmoxWindowEdit',
> + subject: gettext('CPU Set'),
> + items: {
> + xtype: 'inputpanel',
> + items: {
> + xtype: 'textfield',
> + name: 'cpuset',
> + vtype: 'CPUSet',
> + value: '',
> + fieldLabel: gettext('cpuset'),
> + allowBlank: true,
> + emptyText: gettext("Pin to cores (e.g. 0,2-6,8)"),
> + },
> + onGetValues: function(values) {
> + var params = values;
> + if (values.cpuset === undefined ||
> + values.cpuset === null ||
> + values.cpuset === '') {
> + params = { 'delete': 'cpuset' };
> + }
> + return params;
> + },
> + },
> + } : undefined,
> + },
> };
>
> var baseurl = 'nodes/' + nodename + '/qemu/' + vmid + '/config';
Is a string the best way of entering the CPUs in the GUI? Maybe a
dropdown where you can (un)select the cores?
next prev parent reply other threads:[~2022-06-08 14:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 11:54 [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning Daniel Bowder
2022-06-08 11:54 ` [pve-devel] [PATCH 1/5] fix #3593: Added vm core pinning pve-docs Daniel Bowder
2022-06-08 14:20 ` Matthias Heiserer
2022-06-08 11:54 ` [pve-devel] [PATCH 2/5] fix #3593: Added vm core pinning pve-guest-common Daniel Bowder
2022-06-08 11:54 ` [pve-devel] [PATCH 3/5] fix #3593: Added vm core pinning qemu-server Daniel Bowder
2022-06-08 14:45 ` Matthias Heiserer
2022-06-08 11:54 ` [pve-devel] [PATCH 4/5] fix #3593: Added vm core pinning proxmox-widget-toolkit Daniel Bowder
2022-06-08 11:54 ` [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager Daniel Bowder
2022-06-08 14:39 ` Matthias Heiserer [this message]
2022-06-08 13:00 ` [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning Matthias Heiserer
2022-06-08 13:21 ` Daniel Bowder
2022-06-08 13:32 ` Matthias Heiserer
2022-06-08 13:43 ` Daniel Bowder
2022-06-09 15:43 [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager Daniel Bowder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a61550-8621-f620-7631-a61d0a797f8f@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox