public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH container/storage v3] add fsfreeze/thaw for rbd snapshots
Date: Tue, 10 Nov 2020 19:24:31 +0100	[thread overview]
Message-ID: <e1732d08-1975-4c62-23aa-28ef6589e4a9@proxmox.com> (raw)
In-Reply-To: <20201106141942.7643-1-s.ivanov@proxmox.com>

On 06.11.20 15:19, Stoiko Ivanov wrote:
> this patchset addresses #2991 and #2528.
> 
> v2->v3:
> * incoroprated Wolfgang's feedback (huge thanks!!):
> ** /proc/$pid/root contains as magic-link [0] to the container's rootfs -
>    so use these for the FIFREEZE/FITHAW ioctls instead of fork+nsenter
> ** thus moved the fsfreeze_mountpoint to PVE::LXC::Config (it's only needed
>    there)
> 
> [0] https://www.kernel.org/doc/html/latest/filesystems/path-lookup.html


applied series, thanks!




      parent reply	other threads:[~2020-11-10 18:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 14:19 [pve-devel] " Stoiko Ivanov
2020-11-06 14:19 ` [pve-devel] [PATCH storage v3 1/2] fix typo in comment Stoiko Ivanov
2020-11-06 14:19 ` [pve-devel] [PATCH storage v3 2/2] add check for fsfreeze before snapshot Stoiko Ivanov
2020-11-06 14:19 ` [pve-devel] [PATCH container v3 1/2] add fsfreeze helper: Stoiko Ivanov
2020-11-06 14:19 ` [pve-devel] [PATCH container v3 2/2] snapshot creation: fsfreeze mountpoints, if needed Stoiko Ivanov
2020-11-10 18:24 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1732d08-1975-4c62-23aa-28ef6589e4a9@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal