public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 2/2] pvesr: mention how to configure specific network for replication
Date: Wed, 4 Dec 2024 17:08:49 +0100	[thread overview]
Message-ID: <e162d7d2-0cbb-4467-99b3-5a38b42eb3c4@proxmox.com> (raw)
In-Reply-To: <755a2dbb-439d-47ae-bf53-01d39d07bc11@proxmox.com>

I sent a v2 
https://lore.proxmox.com/pve-devel/20241204160749.1868857-1-a.lauterer@proxmox.com/T/#t

On  2024-11-29  16:17, Fiona Ebner wrote:
> Am 05.11.24 um 12:08 schrieb Aaron Lauterer:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>>   pvesr.adoc | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/pvesr.adoc b/pvesr.adoc
>> index 4fc2de1..209f306 100644
>> --- a/pvesr.adoc
>> +++ b/pvesr.adoc
>> @@ -181,6 +181,12 @@ A replication job is identified by a cluster-wide unique ID. This ID is
>>   composed of the VMID in addition to a job number.
>>   This ID must only be specified manually if the CLI tool is used.
>>   
>> +Network
>> +-------
>> +
>> +By default, the replication traffic will choose the management network. To
> Maybe s/choose/use/ ?
> 
>> +place the replication traffic on a specific network, configure the `Migration
>> +Network` over the web interface, `Datacenter -> Options -> Migration Settings`.
> 
> I kinda feel like it's better the other way around:
> Say replication traffic will use the Migration Network (which is also
> used for guest migration) and then say what that is by default and where
> to find it. I'd also mention that it's in the datacenter.cfg
> configuration file via CLI.
> 
> Just nits of course, but if we're already at it ;)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-12-04 16:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 11:08 [pve-devel] [PATCH docs 1/2] pvesr: fix possible issues storage ID Aaron Lauterer
2024-11-05 11:08 ` [pve-devel] [PATCH docs 2/2] pvesr: mention how to configure specific network for replication Aaron Lauterer
2024-11-29 15:17   ` Fiona Ebner
2024-12-04 16:08     ` Aaron Lauterer [this message]
2024-11-29 15:18 ` [pve-devel] applied: [PATCH docs 1/2] pvesr: fix possible issues storage ID Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e162d7d2-0cbb-4467-99b3-5a38b42eb3c4@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal