From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] Handling 'path' requests during VM deletion
Date: Thu, 14 Aug 2025 17:11:54 +0200 [thread overview]
Message-ID: <e15c8778-88dc-4e8f-b2fe-19da6c1f4b1e@proxmox.com> (raw)
In-Reply-To: <mailman.714.1754602793.367.pve-devel@lists.proxmox.com>
Hi Andrei,
Am 07.08.25 um 11:39 PM schrieb Andrei Perapiolkin via pve-devel:
> Hi,
>
> VM deletion retries 'path'/'free_image' for already-removed volumes; expected plugin behavior on missing volumes is unclear.
>
> When deleting a VM with multiple attached volumes, Proxmox deletes volumes sequentially (one at a time) and
> updates the VM record only after all deletions complete.
Could you please file a bug for this: https://bugzilla.proxmox.com ?
> If a volume deletion fails mid-process (e.g., network error), the VM record is not updated even though some volumes may have been successfully removed.
> A subsequent delete attempt repeats all operations, including 'path' (and 'free_image') calls for volumes that were already deleted.
>
>
> What is the proper response to 'path' and 'free_image' calls for a volume that no longer exists?
> For path, should the call fail (e.g., 'die'), succeed with an empty string, or return a 'storage path'?
(Most) implementations of path() for plugins shipped by us [0] do not do
any I/O at all and thus don't check if the image actually exist. So you
can return the path, even if the volume does not exist.
Some of our implementations of free_image() fail if the volume does not
exist, some do not. Nothing should break if you indicate success when
free_image() is called and the image does not exist.
[0]:
https://git.proxmox.com/?p=pve-storage.git;a=tree;f=src/PVE/Storage;h=26012be26cb3c24515e99a02e7ad438f29c81646;hb=HEAD
Best Regards,
Fiona
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-14 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 21:34 Andrei Perapiolkin via pve-devel
2025-08-14 15:11 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e15c8778-88dc-4e8f-b2fe-19da6c1f4b1e@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox