From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server/novnc/manager/docs v8 0/5] Feature VNC-Clipboard
Date: Wed, 17 May 2023 15:48:17 +0200 [thread overview]
Message-ID: <e13b0e7c-6ed9-d42e-6e29-219b6249b8cb@proxmox.com> (raw)
In-Reply-To: <20230503094804.87245-1-m.frank@proxmox.com>
hi
one thing i totally missed until now:
we probably want to use 'vnc-clipboard' instead of 'vnc_clipboard'
(AFAIK we want to use "kebab case" in favor of "snake case")
sorry for not picking this up earlier !
Aside from that the series looks now good to me now.
@thomas, any opinions if the 'vga' config is the right place
and if the split in the gui is ok this way?
prev parent reply other threads:[~2023-05-17 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:47 Markus Frank
2023-05-03 9:48 ` [pve-devel] [PATCH qemu-server v8 1/5] enable clipboard parameter in vga_fmt Markus Frank
2023-05-03 9:48 ` [pve-devel] [PATCH qemu-server v8 2/5] test cases for clipboard spice & std Markus Frank
2023-05-03 9:48 ` [pve-devel] [PATCH novnc v8 3/5] added show clipboard button patch to series Markus Frank
2023-05-03 9:48 ` [pve-devel] [PATCH manager v8 4/5] added clipboard checkbox to VM Options Markus Frank
2023-05-03 9:48 ` [pve-devel] [PATCH docs v8 5/5] added noVNC clipboard documentation Markus Frank
2023-05-17 13:48 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e13b0e7c-6ed9-d42e-6e29-219b6249b8cb@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox