From: Dominik Csapak <d.csapak@proxmox.com>
To: Matthias Heiserer <m.heiserer@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] ui: remove extra parenthesis from check to avoid eslint error
Date: Wed, 15 Feb 2023 16:37:54 +0100 [thread overview]
Message-ID: <e1324fae-9247-4fab-d842-b405702e1887@proxmox.com> (raw)
In-Reply-To: <30cf2d2b-104c-4546-08e4-d813d255c2a9@proxmox.com>
On 2/15/23 16:22, Matthias Heiserer wrote:
> On 15.02.2023 16:03, Dominik Csapak wrote:
>> On 2/15/23 15:46, Stefan Sterz wrote:
>>> with the additional parenthesis eslint throws an error due to the
>>> "no-extra-parens" rule that avoids unnecessary parenthesis. remove
>>> them to get rid of the error.
>>>
>>> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
>>> ---
>>> i am personally not too happy with this eslint requirement here, but
>>> the widget toolkit won't build otherwise.
>>>
>>> src/window/DiskSmart.js | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
>>> index b538ea1..be52a4e 100644
>>> --- a/src/window/DiskSmart.js
>>> +++ b/src/window/DiskSmart.js
>>> @@ -159,7 +159,7 @@ Ext.define('Proxmox.window.DiskSmart', {
>>> {
>>> name: 'real-value',
>>> // FIXME remove with next major release (PBS 3.0)
>>> - calculate: data => (data.normalized ?? false) ? data.raw : data.value,
>>> + calculate: data => data.normalized ?? false ? data.raw : data.value,
>>> },
>>> {
>>> name: 'real-normalized',
>>
>>
>> imho the '?? false' part is unnecessary since that expression will already be coerced to a
>> boolean and null and undefined are falsy...
>>
>> so i'd be happy with
>> ----
>> data.normalized ? data.raw : data.value,
> Then that's bug in my original patch, as we should only fall back to data.raw when data.normalized
> doesn't exist (i.e. old api version).
so if i understand correctly, you want
data.normalized === undefined || data.normalized === null ? data.raw : data.value
?
if normalized is null/undefined return raw, otherwise value?
>> ----
>>
>> any thoughts @thomas?
>>
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>
>>
>
next prev parent reply other threads:[~2023-02-15 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 14:46 Stefan Sterz
2023-02-15 15:03 ` Dominik Csapak
2023-02-15 15:22 ` Matthias Heiserer
2023-02-15 15:37 ` Dominik Csapak [this message]
2023-02-20 10:11 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1324fae-9247-4fab-d842-b405702e1887@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox