From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/2] ui: lvmthin: don't add nodeselector/enable multiple times in edit window
Date: Tue, 21 Mar 2023 10:31:14 +0100 [thread overview]
Message-ID: <e10eadf2-97f5-86e4-6688-2e459aa4d8ec@proxmox.com> (raw)
In-Reply-To: <20230321091610.1416089-1-d.csapak@proxmox.com>
Am 21/03/2023 um 10:16 schrieb Dominik Csapak:
> seemingly an empty array is special for extjs, and if we push into it,
> we overwrite the class definition of that property
>
> this does not happen when something is already in the array, so
> the other edit windows work as expected
>
> to fix it here, remove the empty array entirely, since we already
> create an empty one when we need it
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/storage/LvmThinEdit.js | 2 --
> 1 file changed, 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-03-21 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 9:16 [pve-devel] " Dominik Csapak
2023-03-21 9:16 ` [pve-devel] [PATCH manager 2/2] ui: lvmthin: fix not being able to edit the storage Dominik Csapak
2023-03-21 9:37 ` [pve-devel] applied: " Thomas Lamprecht
2023-03-21 9:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e10eadf2-97f5-86e4-6688-2e459aa4d8ec@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox