From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES storage 0/4] lvm plugin: error handling and locking fixes
Date: Tue, 4 Nov 2025 18:05:59 +0100 [thread overview]
Message-ID: <e0d9071e-7ccf-4a0b-9a40-9c94ad704cba@proxmox.com> (raw)
In-Reply-To: <20251103162330.112603-1-f.ebner@proxmox.com>
On 03/11/2025 17:23, Fiona Ebner wrote:
> Patch 1/4 is improving an error message by including the previously
> captured error.
>
> Patch 2/4 fixes error handling in volume_snapshot_rollback().
> Previously, allocation would be ignored when 'saferemove' was enabled
> on the storage.
>
> Patches 3/4 and 4/4 fix the locking for volume import and snapshot
> operations. Better viewed with "-w" or
> "-w --word-diff=color --word-diff-regex='\w+'".
Thanks for the patch!
I tested the series in my 2-node cluster with shared iSCSI + LVM +
Snapshot-as-volume-chain. My previous reproducer for the metadata
corruption (creating and deleting snapshots of two VMs on the two nodes
in a loop) does not trigger a metadata corruption anymore, so:
Tested-by: Friedrich Weber <f.weber@proxmox.com>
Note I have not tested the parallel import scenario sketched in patch 3/4.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-04 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 16:23 Fiona Ebner
2025-11-03 16:23 ` [pve-devel] [PATCH storage 1/4] lvm plugin: snapshot delete: propagate previously captured error Fiona Ebner
2025-11-03 16:23 ` [pve-devel] [PATCH storage 2/4] lvm plugin: fix error handling in volume_snapshot_rollback() Fiona Ebner
2025-11-03 16:23 ` [pve-devel] [PATCH storage 3/4] lvm plugin: volume import: lock allocation and removal sections Fiona Ebner
2025-11-03 16:23 ` [pve-devel] [PATCH storage 4/4] lvm plugin: snapshot-as-volume-chain: use locking for snapshot operations Fiona Ebner
2025-11-04 17:05 ` Friedrich Weber [this message]
2025-11-04 19:12 ` [pve-devel] applied: [PATCH-SERIES storage 0/4] lvm plugin: error handling and locking fixes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0d9071e-7ccf-4a0b-9a40-9c94ad704cba@proxmox.com \
--to=f.weber@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox