From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/3] ui: add 'font-logos' stylesheet and font files
Date: Fri, 9 Jun 2023 11:28:15 +0200 [thread overview]
Message-ID: <do5gct3hicdlxddbxqxqjv77oh3ywoaqf26p4qdjfdov7yfxdq@llifgm6xz35k> (raw)
In-Reply-To: <5c3f0fe2-8424-4973-5e82-777de63ba8c1@proxmox.com>
On Wed, Jun 07, 2023 at 12:59:23PM +0200, Thomas Lamprecht wrote:
> Am 03/05/2023 um 11:50 schrieb Christoph Heiss:
> > [..]
>
> Please, let's not repeat the mistake again and pull in some binary artefacts in
> manager even if they don't are directly related to it.
>
> Lets set up a separate package, that way we can also give proper attribution
> (even if the license used wouldn't necessarily require it).
>
> I created:
> https://git.proxmox.com/?p=fonts-font-logos.git;a=summary
Thanks, that's great! I will rework the series to use the new package.
>
> It contains a trivial packaging, the build fonts and the CSS file, but with the
> web-font path adopted to use ../fonts/ to load them, just like Font Awesome does.
>
> That way we can add it to pveproxy in a similar manner, please test if that works
> out for you.
next prev parent reply other threads:[~2023-06-09 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:50 [pve-devel] [PATCH manager 0/3] fix #2435: lxc: show distro and privileged status in summary Christoph Heiss
2023-05-03 9:50 ` [pve-devel] [PATCH manager 1/3] ui: clean up remnants of in-tree font-awesome files Christoph Heiss
2023-06-07 10:15 ` [pve-devel] applied: " Thomas Lamprecht
2023-05-03 9:50 ` [pve-devel] [PATCH manager 2/3] ui: add 'font-logos' stylesheet and font files Christoph Heiss
2023-06-07 10:59 ` Thomas Lamprecht
2023-06-09 9:28 ` Christoph Heiss [this message]
2023-05-03 9:50 ` [pve-devel] [PATCH manager 3/3] ui: GuestStatusView: add 'privileged' and 'ostype' fields Christoph Heiss
2023-06-07 11:49 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=do5gct3hicdlxddbxqxqjv77oh3ywoaqf26p4qdjfdov7yfxdq@llifgm6xz35k \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox