From: Gabriel Goller <g.goller@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container v2 3/3] api: return all addresses of an interface
Date: Tue, 7 Jan 2025 15:14:42 +0100 [thread overview]
Message-ID: <dilh56i2iph3jnwxhekpy23r4buhzpninuxi26lxfo3rpra545@otdmwryeyuz3> (raw)
In-Reply-To: <s8osequb62h.fsf@proxmox.com>
On 11.12.2024 15:57, Maximiliano Sandoval wrote:
>
>Gabriel Goller <g.goller@proxmox.com> writes:
>
>> + "ip-addresses" => {
>> + type => 'array',
>> + description => 'All the Addresses of the interface',
>> + optional => 0,
>> + items => {
>> + type => 'object',
>
>I feel 'The addresses of the interface' sounds a bit better. But no
>strong opinion.
>
>Is it intentional that `Addresses` is capitalized? If this is Header
>Capitalization then the word "interface" should be capitalized too.
I agree, thanks for the heads up!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-07 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 15:11 [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab Gabriel Goller
2024-12-10 15:11 ` [pve-devel] [PATCH manager v2 1/3] lxc: show dynamically assigned IPs in " Gabriel Goller
2024-12-10 15:11 ` [pve-devel] [PATCH manager v2 2/3] guest: refactor and reuse AgentIPView for containers Gabriel Goller
2024-12-10 15:11 ` [pve-devel] [PATCH container v2 3/3] api: return all addresses of an interface Gabriel Goller
2024-12-10 17:58 ` Thomas Lamprecht
2025-01-07 14:14 ` Gabriel Goller
2024-12-11 14:57 ` Maximiliano Sandoval
2025-01-07 14:14 ` Gabriel Goller [this message]
2024-12-12 8:02 ` [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab Fabian Grünbichler
2025-01-08 9:32 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dilh56i2iph3jnwxhekpy23r4buhzpninuxi26lxfo3rpra545@otdmwryeyuz3 \
--to=g.goller@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox