[pve-devel] [PATCH storage] esxi plugin: remove invalid fixme

[pve-devel] [PATCH storage] esxi plugin: remove invalid fixme

[Fiona Ebner]

No other plugin activates the storage inside the path() method either.
The caller needs to ensure that the storage is activated before using
the result of path().

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/Storage/ESXiPlugin.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index 6131c51..bedeac8 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src/PVE/Storage/ESXiPlugin.pm
@@ -477,7 +477,6 @@ sub path {
 
     die "storage '$class' does not support snapshots\n" if defined $snapname;
 
-    # FIXME: activate/mount:
     return mount_dir($storeid) . '/' . $volname;
 }
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH storage] esxi plugin: remove invalid fixme

[Wolfgang Bumiller]

applied, thanks

On Fri, May 09, 2025 at 01:31:59PM +0200, Fiona Ebner wrote:
> No other plugin activates the storage inside the path() method either.
> The caller needs to ensure that the storage is activated before using
> the result of path().
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/Storage/ESXiPlugin.pm | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
> index 6131c51..bedeac8 100644
> --- a/src/PVE/Storage/ESXiPlugin.pm
> +++ b/src/PVE/Storage/ESXiPlugin.pm
> @@ -477,7 +477,6 @@ sub path {
>  
>      die "storage '$class' does not support snapshots\n" if defined $snapname;
>  
> -    # FIXME: activate/mount:
>      return mount_dir($storeid) . '/' . $volname;
>  }
>  
> -- 
> 2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel