From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH storage] esxi plugin: remove invalid fixme
Date: Mon, 12 May 2025 10:55:51 +0200 [thread overview]
Message-ID: <dic6m4ybb5bgzedv4nm5hph6thntoapo2u4kyvjblir3ihdmtq@mq4d63ypsdea> (raw)
In-Reply-To: <20250509113159.45653-1-f.ebner@proxmox.com>
applied, thanks
On Fri, May 09, 2025 at 01:31:59PM +0200, Fiona Ebner wrote:
> No other plugin activates the storage inside the path() method either.
> The caller needs to ensure that the storage is activated before using
> the result of path().
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/Storage/ESXiPlugin.pm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
> index 6131c51..bedeac8 100644
> --- a/src/PVE/Storage/ESXiPlugin.pm
> +++ b/src/PVE/Storage/ESXiPlugin.pm
> @@ -477,7 +477,6 @@ sub path {
>
> die "storage '$class' does not support snapshots\n" if defined $snapname;
>
> - # FIXME: activate/mount:
> return mount_dir($storeid) . '/' . $volname;
> }
>
> --
> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-05-12 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 11:31 [pve-devel] " Fiona Ebner
2025-05-12 8:55 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dic6m4ybb5bgzedv4nm5hph6thntoapo2u4kyvjblir3ihdmtq@mq4d63ypsdea \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal