From: Jordyn Hamilton <j.hamilton@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: c.hughes@proxmox.com
Subject: Re: superseded [PATCH common 0/2] Adding D state checking to the run command
Date: Thu, 19 Nov 2026 13:49:51 -0500 [thread overview]
Message-ID: <dff4616e-bbab-4b54-a442-ddc8bc82bad0@proxmox.com> (raw)
In-Reply-To: <20261119145011.8017-1-j.hamilton@proxmox.com>
Superseded by
https://lore.proxmox.com/pve-devel/20261119184502.22359-1-j.hamilton@proxmox.com/T/#u
On 2026-11-19 09:50, Jordyn Hamilton wrote:
> Currently the run command does not have any logic branches to check for
> a D state. This can cause certain processes like `pvereport` to hang
> indefinitely if it encounters a subprocess that ends up in this state.
>
> Adding a logic branch off the timeout error branch to check for a D
> state process that, if encountered, throws a meaningful error and
> terminates. Due to the nature of D states, there is no way to
> programatically fix or terminate a process in a D state, so the error
> message contains the command, the process id, and first steps towards
> debugging.
>
> This change wasn't designed as opt-in/out due to the fact that a D
> state would cause whatever process that calls it to hang indefinitely,
> without proper termination or error messaging, and universally, having a
> proper termination with an error message would provide a better user and
> support experience.
>
> Jordyn Hamilton (2):
> Added subroutine to check process status
> Added logic to check for d state to run subroutine
>
> src/PVE/Cmd.pm | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
prev parent reply other threads:[~2026-11-19 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:50 [PATCH common 0/2] Adding D state checking to the run command Jordyn Hamilton
2026-11-19 14:50 ` [PATCH common 1/2] Added subroutine to check process status Jordyn Hamilton
2026-11-19 15:33 ` Shannon Sterz
2026-11-19 14:50 ` [PATCH common 2/2] Added logic to check for d state to run subroutine Jordyn Hamilton
2026-11-19 15:33 ` Shannon Sterz
2026-11-19 15:33 ` [PATCH common 0/2] Adding D state checking to the run command Shannon Sterz
2026-11-19 18:49 ` Jordyn Hamilton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dff4616e-bbab-4b54-a442-ddc8bc82bad0@proxmox.com \
--to=j.hamilton@proxmox.com \
--cc=c.hughes@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox