* [pve-devel] applied: [PATCH widget-toolkit] improve multiselect behaviour for checkboxmodel
[not found] <20200422072623.364-1-d.csapak@proxmox.com>
@ 2020-10-23 11:28 ` Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2020-10-23 11:28 UTC (permalink / raw)
To: PVE development discussion, Dominik Csapak
On 22.04.20 09:26, Dominik Csapak wrote:
> when using the mode 'MULTI' for the checkbox selection model,
> clicking a row would deselect all others, only clicking exactly on the
> checkbox would select multiple rows
>
> this override makes the whole cell of the checkbox behave like the
> checkbox. This minimizes misclicks from the user.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> btw. the extjs docs lie, the default is not
> 'x-grid-row-checker' but '.x-grid-row-checker'
> so when setting a different class the '.' is not optional
> 20 minutes of my life i will not get back...
>
> Toolkit.js | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>
better late than never, I guess :)
applied, thanks!
FYI: had to use apply it with 3-way merge, as there where some context changes
(possibly the ones from eslint fixes).
> Applying: improve multiselect behaviour for checkboxmodel
> Using index info to reconstruct a base tree...
> A Toolkit.js
> Falling back to patching base and 3-way merge...
> Auto-merging src/Toolkit.js
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-23 11:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200422072623.364-1-d.csapak@proxmox.com>
2020-10-23 11:28 ` [pve-devel] applied: [PATCH widget-toolkit] improve multiselect behaviour for checkboxmodel Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox