From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: PVE development discussion <pve-devel@pve.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] improve multiselect behaviour for checkboxmodel
Date: Fri, 23 Oct 2020 13:28:33 +0200 [thread overview]
Message-ID: <dfc1726d-9dff-7073-490c-4560be9b32dc@proxmox.com> (raw)
In-Reply-To: <20200422072623.364-1-d.csapak@proxmox.com>
On 22.04.20 09:26, Dominik Csapak wrote:
> when using the mode 'MULTI' for the checkbox selection model,
> clicking a row would deselect all others, only clicking exactly on the
> checkbox would select multiple rows
>
> this override makes the whole cell of the checkbox behave like the
> checkbox. This minimizes misclicks from the user.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> btw. the extjs docs lie, the default is not
> 'x-grid-row-checker' but '.x-grid-row-checker'
> so when setting a different class the '.' is not optional
> 20 minutes of my life i will not get back...
>
> Toolkit.js | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>
better late than never, I guess :)
applied, thanks!
FYI: had to use apply it with 3-way merge, as there where some context changes
(possibly the ones from eslint fixes).
> Applying: improve multiselect behaviour for checkboxmodel
> Using index info to reconstruct a base tree...
> A Toolkit.js
> Falling back to patching base and 3-way merge...
> Auto-merging src/Toolkit.js
parent reply other threads:[~2020-10-23 11:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200422072623.364-1-d.csapak@proxmox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfc1726d-9dff-7073-490c-4560be9b32dc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox