From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH] api: sdn: ipams: status: ensure that guest ID is returned as an integer
Date: Fri, 1 Aug 2025 13:47:42 +0200 [thread overview]
Message-ID: <df3ad232-e22e-43ef-8762-cd1badb19b80@proxmox.com> (raw)
In-Reply-To: <20250801114455.85603-1-f.ebner@proxmox.com>
This is for the pve-network repository. Sorry, seems like I haven't
configured the prefix for this in my git config yet.
Am 01.08.25 um 1:45 PM schrieb Fiona Ebner:
> This is a breaking API change intended for PVE 9.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Together with [0] this makes sorting numerically by guest ID work in
> the SDN IPAM UI.
>
> [0] https://lore.proxmox.com/pve-devel/2014f691-aa28-4ab4-91c1-48c1f68d8a54@proxmox.com/T/
>
> src/PVE/API2/Network/SDN/Ipams.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/API2/Network/SDN/Ipams.pm b/src/PVE/API2/Network/SDN/Ipams.pm
> index 89e05ee..9955817 100644
> --- a/src/PVE/API2/Network/SDN/Ipams.pm
> +++ b/src/PVE/API2/Network/SDN/Ipams.pm
> @@ -364,6 +364,8 @@ __PACKAGE__->register_method({
> $entry->{ip} = $ip;
> $entry->{vnet} = $vnet;
>
> + $entry->{vmid} = int($entry->{vmid}) if defined($entry->{vmid});
> +
> push @$result, $entry;
> }
> }
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-01 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 11:44 Fiona Ebner
2025-08-01 11:47 ` Fiona Ebner [this message]
2025-08-01 13:18 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df3ad232-e22e-43ef-8762-cd1badb19b80@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox