public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 0/5] use hostname from DHCP lease if available
Date: Fri, 20 Oct 2023 17:21:41 +0200	[thread overview]
Message-ID: <df0ef220-117d-4080-a082-10bd0a8f52a7@proxmox.com> (raw)
In-Reply-To: <20231020094651.432513-1-c.heiss@proxmox.com>

Am 20/10/2023 um 11:46 schrieb Christoph Heiss:
> DHCP servers can set option 12 ("host-name") for client leases [0],
> telling them about their hostname. It's very much non-invasive and falls
> back to the default values as done currently.
> 
> This came up while talking to Aaron, which he noticed (esp. during
> trainings) that this would be a very useful feature too have.
> 
> I have tested this with the "host-name" entry set and unset, as well as
> any combinations of that with the domain name being set or unset.
> 
> [0] https://datatracker.ietf.org/doc/html/rfc2132#section-3.14
> 
> Christoph Heiss (5):
>   net: move hostname/fqdn regexes into common code
>   run env: retrieve and store hostname from DHCP lease if available
>   proxinstall: use hostname from run env if available
>   tui: use hostname from run env if available
>   tui: add some tests for `NetworkInfo` -> `NetworkOptions` conversion
> 
>  Proxmox/Install/RunEnv.pm            |   4 +
>  Proxmox/Sys/Net.pm                   |  28 ++++++
>  proxinstall                          |  15 +--
>  proxmox-tui-installer/src/options.rs | 132 +++++++++++++++++++++++++--
>  proxmox-tui-installer/src/setup.rs   |   3 +
>  proxmox-tui-installer/src/utils.rs   |   2 +-
>  6 files changed, 169 insertions(+), 15 deletions(-)
> 

applied series, squashed in a trivial fix to fix the tests though, you
probably based of an older git state where the Interface struct doesn't
have the "state" member yet, thanks!




  parent reply	other threads:[~2023-10-20 15:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20  9:46 [pve-devel] " Christoph Heiss
2023-10-20  9:46 ` [pve-devel] [PATCH installer 1/5] net: move hostname/fqdn regexes into common code Christoph Heiss
2023-10-20  9:46 ` [pve-devel] [PATCH installer 2/5] run env: retrieve and store hostname from DHCP lease if available Christoph Heiss
2023-10-20  9:46 ` [pve-devel] [PATCH installer 3/5] proxinstall: use hostname from run env " Christoph Heiss
2023-10-20  9:46 ` [pve-devel] [PATCH installer 4/5] tui: " Christoph Heiss
2023-10-20  9:46 ` [pve-devel] [PATCH installer 5/5] tui: add some tests for `NetworkInfo` -> `NetworkOptions` conversion Christoph Heiss
2023-10-20 15:21 ` Thomas Lamprecht [this message]
2023-10-24  7:45   ` [pve-devel] applied-series: [PATCH installer 0/5] use hostname from DHCP lease if available Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df0ef220-117d-4080-a082-10bd0a8f52a7@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal