From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Yuri Konotopov <ykonotopov@gnome.org>, pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH v5 storage 1/1] fix #254: iscsi: add support for multipath iscsi targets
Date: Fri, 27 Oct 2023 13:47:04 +0200 [thread overview]
Message-ID: <deff85a4-3e45-4787-a7cd-e0d0f9905f2f@proxmox.com> (raw)
In-Reply-To: <20231023174508.385682-2-ykonotopov@gnome.org>
Am 23/10/2023 um 19:45 schrieb Yuri Konotopov:
> With this patch Proxmox now tries to login to all discovered portals in
> case some of them are not logged yet.
> In case of multipath configuration when initially configured portal is
> missing for some reason Proxmox don't lose iscsi storage now and can
> succesfully restore iscsi connection between reboots.
>
> Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
> ---
> src/PVE/Storage.pm | 2 +-
> src/PVE/Storage/ISCSIPlugin.pm | 117 +++++++++++++++++++++++++--------
> 2 files changed, 89 insertions(+), 30 deletions(-)
>
>
applied, with Dominik's R-b and T-b tags, thanks!
I also made two small follow-ups, one unrelated to your change, and
one for small code cleanups like Dominik suggested.
prev parent reply other threads:[~2023-10-27 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231023174508.385682-1-ykonotopov@gnome.org>
[not found] ` <20231023174508.385682-2-ykonotopov@gnome.org>
2023-10-25 13:45 ` [pve-devel] " Dominik Csapak
2023-10-27 11:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deff85a4-3e45-4787-a7cd-e0d0f9905f2f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=ykonotopov@gnome.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox