From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive
Date: Fri, 13 Jan 2023 13:53:10 +0100 [thread overview]
Message-ID: <deda5a6f-17e1-e697-2d67-9ca5a63727e9@proxmox.com> (raw)
In-Reply-To: <20221220103037.890813-1-s.sterz@proxmox.com>
Am 20/12/2022 um 11:30 schrieb Stefan Sterz:
> when a vm is configured to use a physical cd rom drive but there is no
> such drive a cryptic "uninitialized value" error is thrown. this is
> due to `$path` being undefined in `sub print_drive_commandline_full`.
> warn that no cd rom drive is available instead.
>
> note that the error was cosmetic as the vm would start just fine.
>
> forum thread: https://forum.proxmox.com/threads/119592/
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> changes from v3 (thanks @ Thomas Lamprecht):
>
> * use `log_warn` instead of `warn`
> * dont return results of assignments
>
> changes from v2 (thanks @ Fiona Ebner):
>
> * added newline to message
> * cache the fact that no drive is available so we warn only once
> * adjusted error message again
>
> changes from v1:
>
> * make the error message more concise.
> * use shorter forum link for better formatting in commit message
> (thanks @ Fiona Ebner).
>
>
> PVE/QemuServer.pm | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>
applied both patches, thanks!
prev parent reply other threads:[~2023-01-13 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 10:30 [pve-devel] " Stefan Sterz
2022-12-20 10:30 ` [pve-devel] [PATCH qemu-server v4 2/2] cd rom handling: refactor cd rom path helper function Stefan Sterz
2023-01-13 12:53 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deda5a6f-17e1-e697-2d67-9ca5a63727e9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox