[pve-devel] [PATCH container] fix #5761: add the "discard" mount option

[pve-devel] [PATCH container] fix #5761: add the "discard" mount option

[Filip Schauer]

Introduce the "discard" mount option for rootfs and mount points. This
ensures that unused container volume blocks are discarded from the
underlying storage backend when deleting files within the container.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 src/PVE/LXC/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index ce64c4c..e980f8a 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -311,7 +311,7 @@ sub __snapshot_rollback_get_unused {
 cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
 
 
-my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
+my $valid_mount_option_re = qr/(discard|lazytime|noatime|nodev|noexec|nosuid)/;
 
 sub is_valid_mount_option {
     my ($option) = @_;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] fix #5761: add the "discard" mount option

[Fiona Ebner]

Am 09.10.24 um 16:22 schrieb Filip Schauer:
> Introduce the "discard" mount option for rootfs and mount points. This
> ensures that unused container volume blocks are discarded from the
> underlying storage backend when deleting files within the container.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>

However, this misses the UI part or you can get non-editable volumes there.

> ---
>  src/PVE/LXC/Config.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index ce64c4c..e980f8a 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -311,7 +311,7 @@ sub __snapshot_rollback_get_unused {
>  cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
>  
>  
> -my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
> +my $valid_mount_option_re = qr/(discard|lazytime|noatime|nodev|noexec|nosuid)/;
>  
>  sub is_valid_mount_option {
>      my ($option) = @_;


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container] fix #5761: add the "discard" mount option

[Thomas Lamprecht]

Am 09/10/2024 um 16:22 schrieb Filip Schauer:
> Introduce the "discard" mount option for rootfs and mount points. This
> ensures that unused container volume blocks are discarded from the
> underlying storage backend when deleting files within the container.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>  src/PVE/LXC/Config.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!

please add UI integration like Fiona noticed


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] applied: [PATCH container] fix #5761: add the "discard" mount option

[Filip Schauer]

Sent a patch for the UI integration:
https://lists.proxmox.com/pipermail/pve-devel/2024-October/065805.html

On 24/10/2024 16:49, Thomas Lamprecht wrote:
> Am 09/10/2024 um 16:22 schrieb Filip Schauer:
>> Introduce the "discard" mount option for rootfs and mount points. This
>> ensures that unused container volume blocks are discarded from the
>> underlying storage backend when deleting files within the container.
>>
>> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
>> ---
>>   src/PVE/LXC/Config.pm | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
> applied, thanks!
>
> please add UI integration like Fiona noticed


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel