From: Dominik Csapak <d.csapak@proxmox.com>
To: Shan Shaji <s.shaji@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox_login_manager] ui: settings: add privacy policy url link in settings screen
Date: Mon, 7 Jul 2025 08:28:34 +0200 [thread overview]
Message-ID: <debfd98d-a903-4e4a-9dd1-91390f4ba998@proxmox.com> (raw)
In-Reply-To: <DB3CKK74Y8SL.3MC1LJ87XT7MW@noor>
On 7/4/25 16:40, Shan Shaji wrote:
> On Thu Jul 3, 2025 at 4:00 PM CEST, Dominik Csapak wrote:
>>> + backgroundColor: Theme.of(context).colorScheme.surfaceContainer,
>>
>> this change seems to be unrelated?
> This was intended. The change was made to match the backgroundColor of
> `ProxmoxLoginSelector`. Previously it was using the default scaffold
> backgroundColor.
ok. In this case it was not really clear why it was done in this patch, so a short
sentence that this is changed too wouldn't hurt IMHO.
>>
>>> appBar: AppBar(
>>> title: const Text('Settings'),
>>> ),
>>> @@ -45,6 +51,32 @@ class _ProxmoxGeneralSettingsFormState
>>> ProxmoxGeneralSettingsModel.fromLocalStorage();
>>> });
>>> },
>>> + ),
>>> + PveSettingsSection(
>>> + title: 'LEGAL',
>>> + children: [
>>> + PveSettingsItem(
>>> + titleString: 'Privacy Policy',
>>> + leadingIcon: Icons.privacy_tip_outlined,
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-07 6:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 11:19 Shan Shaji
2025-07-03 14:00 ` Dominik Csapak
2025-07-04 7:16 ` Shan Shaji
2025-07-04 7:31 ` Dominik Csapak
2025-07-04 9:34 ` Thomas Lamprecht
2025-07-04 12:11 ` Shan Shaji
2025-07-04 14:40 ` Shan Shaji
2025-07-07 6:28 ` Dominik Csapak [this message]
2025-07-07 7:09 ` Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=debfd98d-a903-4e4a-9dd1-91390f4ba998@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox