public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, d.whyte@proxmox.com
Subject: Re: [pve-devel] [PATCH pve-docs 5/6] pvecm: add note about corosync killnode error
Date: Thu, 16 Sep 2021 10:04:57 +0200	[thread overview]
Message-ID: <de83ac0a-2fc2-4731-3e70-466697b81cfc@proxmox.com> (raw)
In-Reply-To: <20210915133618.143859-5-d.whyte@proxmox.com>

Am 15.09.21 um 15:36 schrieb Dylan Whyte:
> Mentions the misleading error message shown, when deleting a node,
> because of the failing command:
>      corosync-cfgtool -k x
> 
> Some forum users were confused by this, and believed that the removal of
> the node was unsuccessful.
> 
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
>   pvecm.adoc | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/pvecm.adoc b/pvecm.adoc
> index af9cf33..e7140a6 100644
> --- a/pvecm.adoc
> +++ b/pvecm.adoc
> @@ -340,6 +340,11 @@ After powering off the node hp4, we can safely remove it from the cluster.
>    Killing node 4
>   ----
>   
> +NOTE: At this point, it is possible that you will receive an error message
> +stating `Could not kill node (error = CS_ERR_NOT_EXIST)`. This does not
> +signify an actual failure in the deletion of the node, but rather a failure in
> +corosync trying to kill an offline node. Thus, it can be safely ignored.
> +

Currently our API call/CLI command fails in this scenario. Can we 
reliably detect the situation and not run
     corosync-cfgtool -k x
then? Or always run it to be sure, but gracefully catch the specific 
error and print it as a warning (maybe adding something like "- node 
already offline?") instead of failing?

>   Use `pvecm nodes` or `pvecm status` to check the node list again. It should
>   look something like:
>   
> 




  reply	other threads:[~2021-09-16  8:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 13:36 [pve-devel] [PATCH pve-docs 1/6] pvecm: language and format fixup Dylan Whyte
2021-09-15 13:36 ` [pve-devel] [PATCH pve-docs 2/6] pvecm: replace {PVE} with {pve} Dylan Whyte
2021-09-15 13:36 ` [pve-devel] [PATCH pve-docs 3/6] pvecm: fix command output formatting Dylan Whyte
2021-09-15 13:36 ` [pve-devel] [PATCH pve-docs 4/6] pvecm: update instructions to add redundant links Dylan Whyte
2021-09-15 13:36 ` [pve-devel] [PATCH pve-docs 5/6] pvecm: add note about corosync killnode error Dylan Whyte
2021-09-16  8:04   ` Fabian Ebner [this message]
2021-09-15 13:36 ` [pve-devel] [PATCH pve-docs 6/6] fix 3375: warn user to remove replication jobs Dylan Whyte
2021-09-15 15:03 ` [pve-devel] applied-series: [PATCH pve-docs 1/6] pvecm: language and format fixup Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de83ac0a-2fc2-4731-3e70-466697b81cfc@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.whyte@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal