[pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist

[pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist

[Shan Shaji]

The app was crashing on iOS when trying to access the biometric storage
to access the saved password. The crash was due to a missing key inside
the `Info.plist` file [0]. This patch fixes it by adding the missing
`NSFaceIDUsageDescription` key inside the `Info.plist` file.

- [0]
https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 ios/Runner/Info.plist | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist
index ef3f061..825d78d 100644
--- a/ios/Runner/Info.plist
+++ b/ios/Runner/Info.plist
@@ -24,6 +24,8 @@
 	<string>$(FLUTTER_BUILD_NUMBER)</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
+	<key>NSFaceIDUsageDescription</key>
+	<string>Use Face ID for a faster and more convenient login experience.</string>
 	<key>UILaunchStoryboardName</key>
 	<string>LaunchScreen</string>
 	<key>UIMainStoryboardFile</key>
-- 
2.39.5 (Apple Git-154)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist

[Shan Shaji]

Ping

On Tue May 13, 2025 at 12:32 PM CEST, Shan Shaji wrote:
> The app was crashing on iOS when trying to access the biometric storage
> to access the saved password. The crash was due to a missing key inside
> the `Info.plist` file [0]. This patch fixes it by adding the missing
> `NSFaceIDUsageDescription` key inside the `Info.plist` file.
>
> - [0]
> https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  ios/Runner/Info.plist | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist
> index ef3f061..825d78d 100644
> --- a/ios/Runner/Info.plist
> +++ b/ios/Runner/Info.plist
> @@ -24,6 +24,8 @@
>  	<string>$(FLUTTER_BUILD_NUMBER)</string>
>  	<key>LSRequiresIPhoneOS</key>
>  	<true/>
> +	<key>NSFaceIDUsageDescription</key>
> +	<string>Use Face ID for a faster and more convenient login experience.</string>
>  	<key>UILaunchStoryboardName</key>
>  	<string>LaunchScreen</string>
>  	<key>UIMainStoryboardFile</key>
> -- 
> 2.39.5 (Apple Git-154)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist

[Aaron Lauterer]

LGTM.

Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2025-05-13  12:32, Shan Shaji wrote:
> The app was crashing on iOS when trying to access the biometric storage
> to access the saved password. The crash was due to a missing key inside
> the `Info.plist` file [0]. This patch fixes it by adding the missing
> `NSFaceIDUsageDescription` key inside the `Info.plist` file.
> 
> - [0]
> https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   ios/Runner/Info.plist | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist
> index ef3f061..825d78d 100644
> --- a/ios/Runner/Info.plist
> +++ b/ios/Runner/Info.plist
> @@ -24,6 +24,8 @@
>   	<string>$(FLUTTER_BUILD_NUMBER)</string>
>   	<key>LSRequiresIPhoneOS</key>
>   	<true/>
> +	<key>NSFaceIDUsageDescription</key>
> +	<string>Use Face ID for a faster and more convenient login experience.</string>
>   	<key>UILaunchStoryboardName</key>
>   	<string>LaunchScreen</string>
>   	<key>UIMainStoryboardFile</key>



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist

[Thomas Lamprecht]

On Tue, 13 May 2025 12:32:00 +0200, Shan Shaji wrote:
> The app was crashing on iOS when trying to access the biometric storage
> to access the saved password. The crash was due to a missing key inside
> the `Info.plist` file [0]. This patch fixes it by adding the missing
> `NSFaceIDUsageDescription` key inside the `Info.plist` file.
> 
> - [0]
> https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription
> 
> [...]

Applied, thanks!

[1/1] fix: ios: include the `NSFaceIDUsageDescription` in info.plist
      commit: cef02a66392ab651108fddd59d2d142e6a75133f


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel