public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"t.lamprecht@proxmox.com" <t.lamprecht@proxmox.com>,
	"aderumier@odiso.com" <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature
Date: Thu, 11 Nov 2021 18:38:43 +0000	[thread overview]
Message-ID: <de0997236212fce65960ad1de8c634c05291e279.camel@groupe-cyllene.com> (raw)
In-Reply-To: <179fb53f-5dff-8d3a-38b6-a392b9bcb581@proxmox.com>

Le jeudi 11 novembre 2021 à 11:40 +0100, Thomas Lamprecht a écrit :
On 24.09.21 10:48, Alexandre Derumier wrote:
Currently, if bridge receive an unknown dest mac (network bug/attack/..),
we are flooding packets to all bridge ports.

This can waste cpu time, even more with firewall enabled.
Also, if firewall is used with reject action, the src mac of RST
packet is the original unknown dest mac.
(This can block the server at Hetzner for example)

So, we can disable learning && unicast_flood on tap|veth|fwln port interface.
Then mac address need to be add statically in bridge fdb.

I'm a bit out of the loop of the with the whole bad hetzner network thingy, is this still
relevant as I'd see if I can get it in finally..

yes, it can still help with hetzner.
it should allow to use REJECT rules in firewall, as the reject rst packet src ip,is the original dst ip.
when bad traffic is flooded up to the fwbr bridge with unknown dst mac/ip. (because bridges are in promisc mode).



I think this patch series could be usefull for some sdn controllers,

like evpn, where we can statically register mac, but also ip address (not yet implement in this patch serie) in the controlplane.
(instead of using arp dynamic registration, this can have problem sometime with silent hosts and arp timeout)
they are also some sdn (not yet implement, but faucet sdn or some openflow sdn controller), where mac/ip registration really need to be done statically at vm start.


  parent reply	other threads:[~2021-11-11 18:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  8:48 Alexandre Derumier
2021-09-24  8:48 ` [pve-devel] [PATCH pve-common 1/2] network: add support for disabling bridge learning on tap|veth|fwln ports Alexandre Derumier
2021-09-24  8:48 ` [pve-devel] [PATCH pve-common 2/2] Inotify: add bridge-disable-mac-learning option to bridges Alexandre Derumier
2021-11-11 10:40 ` [pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature Thomas Lamprecht
2021-11-11 10:46   ` Josef Johansson
2021-11-11 18:38   ` DERUMIER, Alexandre [this message]
2022-03-16 16:33 ` [pve-devel] applied-series: " Thomas Lamprecht
2022-03-16 16:43   ` DERUMIER, Alexandre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de0997236212fce65960ad1de8c634c05291e279.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal