public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH storage 1/1] status: rrddata: use fixed pve-storage-9.0 path
Date: Fri, 12 Sep 2025 19:48:49 +0200	[thread overview]
Message-ID: <dde1a09f-448c-4cc9-b5e1-63b3f039da73@proxmox.com> (raw)
In-Reply-To: <20250905135517.4005478-8-a.lauterer@proxmox.com>

Reviewed-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
Tested-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>


On 05.09.25 15:55, Aaron Lauterer wrote:
> Because we now always create it, should it not exists and old data is
> used from the old files.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>   src/PVE/API2/Storage/Status.pm | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
> index ad8c753..94fed9b 100644
> --- a/src/PVE/API2/Storage/Status.pm
> +++ b/src/PVE/API2/Storage/Status.pm
> @@ -415,10 +415,11 @@ __PACKAGE__->register_method({
>       code => sub {
>           my ($param) = @_;
>   
> -        my $path = "pve-storage-9.0/$param->{node}/$param->{storage}";
> -        $path = "pve2-storage/$param->{node}/$param->{storage}"
> -            if !-e "/var/lib/rrdcached/db/${path}";
> -        return PVE::RRD::create_rrd_data($path, $param->{timeframe}, $param->{cf});
> +        return PVE::RRD::create_rrd_data(
> +            "pve-storage-9.0/$param->{node}/$param->{storage}",
> +            $param->{timeframe},
> +            $param->{cf},
> +        );
>       },
>   });
>   



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-09-12 17:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 13:55 [pve-devel] [PATCH cluster/container/manager/qemu-server/storage 0/7] combine and simplify RRD handling Aaron Lauterer
2025-09-05 13:55 ` [pve-devel] [PATCH cluster 1/3] rrd: fix rrd time frames Aaron Lauterer
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu
2025-09-05 13:55 ` [pve-devel] [PATCH cluster 2/3] RRD: fetch data from old rrd file if present and needed Aaron Lauterer
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu
2025-09-05 13:55 ` [pve-devel] [PATCH cluster 3/3] pmxcfs: status.c: always use 9.0 rrd files Aaron Lauterer
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu
2025-09-05 13:55 ` [pve-devel] [PATCH manager 1/1] status: rrddata: use fixed pve-node-9.0 path Aaron Lauterer
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu
2025-09-05 13:55 ` [pve-devel] [PATCH qemu-server 1/1] status: rrddata: use fixed pve-vm-9.0 path Aaron Lauterer
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu
2025-09-05 13:55 ` [pve-devel] [PATCH container " Aaron Lauterer
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu
2025-09-05 13:55 ` [pve-devel] [PATCH storage 1/1] status: rrddata: use fixed pve-storage-9.0 path Aaron Lauterer
2025-09-12 17:48   ` Laurențiu Leahu-Vlăducu [this message]
2025-09-12 17:47 ` [pve-devel] [PATCH cluster/container/manager/qemu-server/storage 0/7] combine and simplify RRD handling Laurențiu Leahu-Vlăducu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dde1a09f-448c-4cc9-b5e1-63b3f039da73@proxmox.com \
    --to=l.leahu-vladucu@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal