From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 proxmox-openid-rs] fix Open ID with Azure as provider
Date: Fri, 1 Apr 2022 11:40:00 +0200 [thread overview]
Message-ID: <ddc91495-a379-ed3d-f4df-c3049e8093e9@proxmox.com> (raw)
In-Reply-To: <20220401093202.122978-1-m.limbeck@proxmox.com>
On 4/1/22 11:32, Mira Limbeck wrote:
> Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint,
> but with the switch to ureq we always send requests with this set.
>
> Fix by switching to `Content-Length` in the header instead. ureq only
> sets `Transfer-Encoding: chunked` when the body length is not known
> beforehand, which is the case when using `send`. See
> https://docs.rs/ureq/2.4.0/ureq/index.html#content-length-and-transfer-encoding
>
> See https://forum.proxmox.com/threads/openid-401-with-azure-ad.105892/
> for the issue.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
> - added inline comment
> - removed the unnecessary `let bytes = ...` line
> - changed link in commit message to versioned docs.rs
>
> probably also fixes https://bugzilla.proxmox.com/show_bug.cgi?id=3916,
> but I could only reproduce this exact error message with Azure until
> now.
>
> src/http_client.rs | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/http_client.rs b/src/http_client.rs
> index a2bf6ee..1a16ff3 100644
> --- a/src/http_client.rs
> +++ b/src/http_client.rs
> @@ -75,7 +75,10 @@ pub fn http_client(request: HttpRequest) -> Result<HttpResponse, Error> {
> }
>
> let response = if let Method::POST = request.method {
> - req.send(&*request.body)
> + // send_bytes makes sure that Content-Length is set. This is important, because some
> + // endpoints don't accept `Transfer-Encoding: chunked`, which would otherwise be set.
> + // see https://github.com/algesten/ureq/blob/main/README.md#content-length-and-transfer-encoding
> + req.send_bytes(request.body.as_slice())
> } else {
> req.call()
> }
disregard this patch, it contains the wrong link in the inline comment
will send a v3
prev parent reply other threads:[~2022-04-01 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 9:32 Mira Limbeck
2022-04-01 9:40 ` Mira Limbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc91495-a379-ed3d-f4df-c3049e8093e9@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox