From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] applied: [RFC manager] api: replication: allow users to enumerate accessible replication jobs
Date: Mon, 4 Dec 2023 16:54:10 +0100 [thread overview]
Message-ID: <dd70fd78-c8e1-4259-8025-9d9efe0917e9@proxmox.com> (raw)
In-Reply-To: <20231201132409.153256-1-l.wagner@proxmox.com>
Am 01/12/2023 um 14:24 schrieb Lukas Wagner:
> Previously, the /cluster/replication API handler would fail completely
> with a HTTP 403 if a user does have VM.Audit permissions for
> a single VM/CT. That was due to the 'noerr' parameter not set for
> $rpcenv->check()
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> Not sure if this violates our API stability guarantees, so I'm sending
> this as an RFC in advance. If this change is problematic, we could
> hide the new behavior behind an optional flag.
>
> This change is necessary for retrieving a list of known job-ids for
> enhancements to the notification matching rule edit window.
>
> PVE/API2/ReplicationConfig.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, with Fabian's R-b tag, thanks!
prev parent reply other threads:[~2023-12-04 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 13:24 [pve-devel] " Lukas Wagner
2023-12-04 13:39 ` Fabian Grünbichler
2023-12-04 15:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd70fd78-c8e1-4259-8025-9d9efe0917e9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox