From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 0/2] refresh affinity rules on edit to display conflicts
Date: Sat, 2 Aug 2025 19:31:29 +0200 [thread overview]
Message-ID: <dd3eac01-c37a-483c-9483-510db3a69bb0@proxmox.com> (raw)
In-Reply-To: <20250801165845.97353-1-m.koeppl@proxmox.com>
Am 01.08.25 um 18:58 schrieb Michael Köppl:
> The goal of this is to refresh both affinity rules stores to
> immediately display any conflicts. Without this change, users have to
> refresh the page to see conflicts on resource affinity rules after they
> added a node affinity rule that was in conflict (and vice-versa).
I went a bit of another route[0][1] that has also the advantage of
not loading the same data twice which in turn also avoids not being
potentially out-of-sync due to those twice loads returning a
potentially different state.
Thanks nonetheless for shining light to this issue, that was very
helpful to me and allowed for some more code clean-ups–the original
HA groups UI was a bit dated as it was added in 2015 where we did
not used the more modern capabilities from ExtJS that allow a bit
more declarative coding style by, e.g., encapsulating more logic
to view controllers.
[0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=566ec7fdb80887cc59cd5b9946b44a7e747e2ad3
[1]: https://lore.proxmox.com/pve-devel/20250802172619.3692858-2-t.lamprecht@proxmox.com/T/#u
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-02 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 16:58 Michael Köppl
2025-08-01 16:58 ` [pve-devel] [PATCH manager 1/2] ui: ha: refresh rules lists on edit to display conflicts immediately Michael Köppl
2025-08-01 16:58 ` [pve-devel] [PATCH manager 2/2] run make tidy Michael Köppl
2025-08-02 12:51 ` Thomas Lamprecht
2025-08-02 17:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd3eac01-c37a-483c-9483-510db3a69bb0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox