From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] Fix ACPI-suspended VMs resuming after migration
Date: Thu, 24 Aug 2023 14:45:32 +0200 [thread overview]
Message-ID: <dd18a16c-c8bd-e4ca-c99f-052c07b9034a@proxmox.com> (raw)
In-Reply-To: <20230823105839.36751-1-f.schauer@proxmox.com>
Am 23.08.23 um 12:58 schrieb Filip Schauer:
> When migrating a VM that suspended itself via ACPI, it will no longer be
> resumed automatically.
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
At a first glance, it seems like the other callers of vm_is_paused()
could also benefit from treating the 'suspended' runstate the same way
as 'paused'. Can you please check that and instead add the check for
'suspended' directly to the vm_is_paused() function? If you can come up
with a good name it might make sense to rename the function too, or at
least add a comment saying that the "paused" does not mean only the
runstate 'paused' but includes other runstates where the VM is paused ;)
And we might want to treat the runstate 'prelaunch' as paused too.
There's also runstates for being paused during certain phases of
migration, but maybe we can ignore them for now. Shouldn't be strictly
required, because of our config locking.
Full list would be here:
https://qemu.readthedocs.io/en/v8.0.0/interop/qemu-qmp-ref.html#qapidoc-85
prev parent reply other threads:[~2023-08-24 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 10:58 Filip Schauer
2023-08-24 12:45 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd18a16c-c8bd-e4ca-c99f-052c07b9034a@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox