From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/3] node console: restrict all non-login commands to root@pam
Date: Mon, 6 Nov 2023 15:38:52 +0100 [thread overview]
Message-ID: <dcf265a0-3fb3-4e87-8483-fbcbc111ea69@proxmox.com> (raw)
In-Reply-To: <20230614104215.359768-2-f.gruenbichler@proxmox.com>
Am 14/06/2023 um 12:42 schrieb Fabian Grünbichler:
> and not just upgrade.
>
> note that the only other non-login command (ceph_install) is restricted to
> root@pam in the web UI anyway, and that the termproxy endpoint is lacking this
> check and thus always falls back to a login prompt for non-login commands
> requested by non-root users.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> PVE/API2/Nodes.pm | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2023-11-06 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 10:42 [pve-devel] [PATCH manager 0/3] rework node console permission checks Fabian Grünbichler
2023-06-14 10:42 ` [pve-devel] [PATCH manager 1/3] node console: restrict all non-login commands to root@pam Fabian Grünbichler
2023-11-06 14:38 ` Thomas Lamprecht [this message]
2023-06-14 10:42 ` [pve-devel] [PATCH manager 2/3] node console: allow usage for non-pam realms Fabian Grünbichler
2023-11-06 14:38 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-14 10:42 ` [pve-devel] [RFC manager 3/3] node console: lift root@pam restriction for commands Fabian Grünbichler
2023-11-06 14:46 ` Thomas Lamprecht
2023-11-06 7:36 ` [pve-devel] [PATCH manager 0/3] rework node console permission checks Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcf265a0-3fb3-4e87-8483-fbcbc111ea69@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox