From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH-SERIES storage/manager/guest-common/docs] improvements for protected backups
Date: Thu, 10 Mar 2022 08:46:55 +0100 [thread overview]
Message-ID: <dc29a3a9-9635-db51-d0c9-90739738e8ed@proxmox.com> (raw)
In-Reply-To: <20211216121233.162288-1-f.ebner@proxmox.com>
Ping for the series. Or do we not want the limit after all (as far as
I'm aware, nobody complained yet)?
Am 16.12.21 um 13:12 schrieb Fabian Ebner:
> The series consists of two parts:
>
> First part (up to docs 2/2) is for introducing a storage property
> to limit the number of protected backups and only count unprotected
> backups for the limit check in vzdump.
>
> Second part is a convenience feature allowing 'protected' and 'notes'
> to be set directly with vzdump and for manual backups in the UI.
>
>
> storage:
>
> Fabian Ebner (2):
> list volumes: also return backup type for backups
> plugins: allow limiting the number of protected backups per guest
>
> PVE/Storage.pm | 24 ++++++++++++++++++++++++
> PVE/Storage/BTRFSPlugin.pm | 3 ++-
> PVE/Storage/CIFSPlugin.pm | 1 +
> PVE/Storage/CephFSPlugin.pm | 1 +
> PVE/Storage/DirPlugin.pm | 1 +
> PVE/Storage/GlusterfsPlugin.pm | 1 +
> PVE/Storage/NFSPlugin.pm | 1 +
> PVE/Storage/PBSPlugin.pm | 2 ++
> PVE/Storage/Plugin.pm | 8 ++++++++
> test/list_volumes_test.pm | 10 ++++++++++
> 10 files changed, 51 insertions(+), 1 deletion(-)
>
>
> manager:
>
> Fabian Ebner (6):
> vzdump: backup file list: drop unused parameter
> vzdump: backup limit: only count unprotected backups
> ui: storage edit: retention: add max-protected-backups setting
> ui: storage creation: retention: dynamically adapt
> max-protected-backups
> vzdump: support setting protected status and notes
> ui: backup: allow setting protected and notes for manual backup
>
> PVE/VZDump.pm | 69 ++++++++++++++++++---------
> www/manager6/panel/BackupJobPrune.js | 71 ++++++++++++++++++++++++----
> www/manager6/storage/Base.js | 1 +
> www/manager6/window/Backup.js | 25 +++++++++-
> 4 files changed, 132 insertions(+), 34 deletions(-)
>
>
> guest-common:
>
> Fabian Ebner (1):
> vzdump: schema: add 'notes' and 'protected' properties
>
> src/PVE/VZDump/Common.pm | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
>
> docs:
>
> Fabian Ebner (2):
> storage: switch to prune-backups in examples
> vzdump/storage: mention protected backups limit and give an example
>
> pve-storage-dir.adoc | 9 +++++----
> pve-storage-pbs.adoc | 2 +-
> vzdump.adoc | 3 +++
> 3 files changed, 9 insertions(+), 5 deletions(-)
>
prev parent reply other threads:[~2022-03-10 7:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:12 Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [PATCH storage 1/2] list volumes: also return backup type for backups Fabian Ebner
2022-03-16 16:42 ` [pve-devel] applied: " Thomas Lamprecht
2021-12-16 12:12 ` [pve-devel] [PATCH storage 2/2] plugins: allow limiting the number of protected backups per guest Fabian Ebner
2022-03-16 16:42 ` Thomas Lamprecht
2022-03-17 8:03 ` Fabian Ebner
2022-03-17 8:11 ` Thomas Lamprecht
2021-12-16 12:12 ` [pve-devel] [PATCH manager 1/6] vzdump: backup file list: drop unused parameter Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [PATCH manager 2/6] vzdump: backup limit: only count unprotected backups Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [RFC manager 3/6] ui: storage edit: retention: add max-protected-backups setting Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [RFC manager 4/6] ui: storage creation: retention: dynamically adapt max-protected-backups Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [PATCH docs 1/2] storage: switch to prune-backups in examples Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [PATCH docs 2/2] vzdump/storage: mention protected backups limit and give an example Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [PATCH guest-common 1/1] vzdump: schema: add 'notes' and 'protected' properties Fabian Ebner
2022-03-16 11:04 ` Fabian Ebner
2022-03-16 18:25 ` Thomas Lamprecht
2022-03-17 7:57 ` Fabian Ebner
2022-03-17 8:07 ` Thomas Lamprecht
2022-03-17 8:18 ` Fabian Ebner
2022-03-17 8:20 ` Thomas Lamprecht
2021-12-16 12:12 ` [pve-devel] [PATCH manager 5/6] vzdump: support setting protected status and notes Fabian Ebner
2021-12-16 12:12 ` [pve-devel] [PATCH manager 6/6] ui: backup: allow setting protected and notes for manual backup Fabian Ebner
2021-12-20 10:31 ` [pve-devel] [PATCH-SERIES storage/manager/guest-common/docs] improvements for protected backups Dominik Csapak
2021-12-21 15:11 ` Thomas Lamprecht
2021-12-22 7:02 ` Dominik Csapak
2022-01-03 9:12 ` Fabian Ebner
2022-03-10 7:46 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc29a3a9-9635-db51-d0c9-90739738e8ed@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox