public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/1] fix #1905: Allow moving unused disks
Date: Mon, 19 Feb 2024 13:22:53 +0100	[thread overview]
Message-ID: <db712622-4884-42a7-ae9e-c7032a418892@proxmox.com> (raw)
In-Reply-To: <20240219111140.40722-2-f.schauer@proxmox.com>

Am 19/02/2024 um 12:11 schrieb Filip Schauer:
> Allow moving unused/detached disks to another storage.

this is a repetition of the commit subject, while that is on it's
own OK, I'd rather see a description about why this is OK to do, i.e.,
why was the original check added, what changed since then, what are
the drawbacks, e.g., as the QEMU block-mirror cannot be used I imagine
only a limited set of source storage to target storage can be used
for this?




  reply	other threads:[~2024-02-19 12:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 11:11 [pve-devel] [PATCH many] " Filip Schauer
2024-02-19 11:11 ` [pve-devel] [PATCH qemu-server 1/1] " Filip Schauer
2024-02-19 12:22   ` Thomas Lamprecht [this message]
2024-03-05 13:12     ` Filip Schauer
2024-02-19 11:11 ` [pve-devel] [PATCH manager 1/1] Allow moving unused disks to another storage Filip Schauer
2024-04-12  9:51 ` [pve-devel] applied-series: [PATCH many] fix #1905: Allow moving unused disks Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db712622-4884-42a7-ae9e-c7032a418892@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal