From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] live-restore: preload efidisk before starting VM
Date: Thu, 1 Jul 2021 12:57:35 +0200 [thread overview]
Message-ID: <db0d50d1-4c14-1d7d-d5c7-1805bbcf665c@proxmox.com> (raw)
In-Reply-To: <20210701093729.2537908-1-s.reiter@proxmox.com>
On 01.07.21 11:37, Stefan Reiter wrote:
> The efidisk never got restored correctly before, since we don't use the
> generic print_drive_commandline_full for it, and as such it didn't get a
> backing image attached. This not only causes the efidisk data to be lost
> on restore, but also an error at the end, since we try to remove a
> non-existing PBS blockdev.
>
> Since it is attached differently to a regular drive, adding PBS backing
> would be more difficult, but not to worry: an efidisk is small enough
> that it doesn't hurt performance to just restore it via the regular
> mechanism before starting the VM, and simply excluding it from the live
> restore entirely.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> best viewed with -w
>
> I guess in QEMU < 6.0 this didn't cause an error, since I definitely tested with
> EFI VMs before, however, it would have never actually restored the data and
> instead always created a new one.
could still be good to backport, I'd figure?
>
> PVE/QemuServer.pm | 46 ++++++++++++++++++++++++----------------------
> 1 file changed, 24 insertions(+), 22 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-07-01 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 9:37 [pve-devel] " Stefan Reiter
2021-07-01 10:57 ` Thomas Lamprecht [this message]
2021-07-01 10:59 ` [pve-devel] applied: " Stefan Reiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db0d50d1-4c14-1d7d-d5c7-1805bbcf665c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox