public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: add version to extjs script urls
Date: Mon, 6 Sep 2021 13:00:15 +0200	[thread overview]
Message-ID: <d98135c4-35c3-a3ec-e258-6e04b507fdc3@proxmox.com> (raw)
In-Reply-To: <20210906101908.2155602-1-d.csapak@proxmox.com>

On 06.09.21 12:19, Dominik Csapak wrote:
> so that we circumvent browsers caching 6.0 extjs js/css
> 
> also depend on extjs 7.0.0 in debian control
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this should (at least for new users upgrading) fix the browser caching
> issue for extjs (we had some now in the forums)
> 
> i did it this way since we do not often change version of the extjs
> package (since its a big task everytime anyway), but if wanted i can
> do it differently. e.g.:
>     * hardcode it in the perl code
>     * generate it during the build (also for the control file)
> 
> but imho this is fine for extjs
> 

I put above info with only slight adaptions in the commit message, IMO such
reasoning is very valuable information that should be archived in source control.

>  debian/control     |  2 +-
>  www/index.html.tpl | 14 +++++++-------
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2021-09-06 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 10:19 [pve-devel] " Dominik Csapak
2021-09-06 11:00 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d98135c4-35c3-a3ec-e258-6e04b507fdc3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal