[pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node

[pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node

[Matthias Heiserer]

One step of installing ceph is creating a monitor. When installing via
the datacenter and from a node other than the first node, clicking "next"
without changing the monitor node could result in the error 
'binary not installed: /usr/bin/ceph-mon', as it would try to install
the monitor on the first node, although ceph was installed on the current
node.

With this patch, the current node is preselected.
This has no effect when installing ceph on a specific node, as the node
selector overwrites the preferred value in that case.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 www/manager6/ceph/CephInstallWizard.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
index 59458b0d..ebdc7f1d 100644
--- a/www/manager6/ceph/CephInstallWizard.js
+++ b/www/manager6/ceph/CephInstallWizard.js
@@ -403,6 +403,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
 		    name: 'mon-node',
 		    selectCurNode: true,
 		    allowBlank: false,
+		    preferredValue: Proxmox.NodeName,
 		},
 		{
 		    xtype: 'displayfield',
-- 
2.30.2

Re: [pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node

[Thomas Lamprecht]

Am 5/5/22 um 16:27 schrieb Matthias Heiserer:
> One step of installing ceph is creating a monitor. When installing via
> the datacenter and from a node other than the first node, clicking "next"
> without changing the monitor node could result in the error 
> 'binary not installed: /usr/bin/ceph-mon', as it would try to install
> the monitor on the first node, although ceph was installed on the current
> node.
> 
> With this patch, the current node is preselected.
> This has no effect when installing ceph on a specific node, as the node
> selector overwrites the preferred value in that case.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  www/manager6/ceph/CephInstallWizard.js | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
> index 59458b0d..ebdc7f1d 100644
> --- a/www/manager6/ceph/CephInstallWizard.js
> +++ b/www/manager6/ceph/CephInstallWizard.js
> @@ -403,6 +403,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
>  		    name: 'mon-node',
>  		    selectCurNode: true,
>  		    allowBlank: false,
> +		    preferredValue: Proxmox.NodeName,

That is always the local node one is connected through the web interface.
So, what if I'm connected through Node A but currently installing/initializing ceph on Node B?
Should this rather be the node currently selected in the resource tree?

>  		},
>  		{
>  		    xtype: 'displayfield',

Re: [pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node

[Matthias Heiserer]

On 06.05.2022 10:00, Thomas Lamprecht wrote:
> Am 5/5/22 um 16:27 schrieb Matthias Heiserer:

>>   www/manager6/ceph/CephInstallWizard.js | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
>> index 59458b0d..ebdc7f1d 100644
>> --- a/www/manager6/ceph/CephInstallWizard.js
>> +++ b/www/manager6/ceph/CephInstallWizard.js
>> @@ -403,6 +403,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
>>   		    name: 'mon-node',
>>   		    selectCurNode: true,
>>   		    allowBlank: false,
>> +		    preferredValue: Proxmox.NodeName,
> 
> That is always the local node one is connected through the web interface.
> So, what if I'm connected through Node A but currently installing/initializing ceph on Node B?
> Should this rather be the node currently selected in the resource tree?

Well, yes, the node selector already does that. This patch only changes 
the behavior when installing ceph after selecting the datacenter in the 
GUI. In which case ceph is installed on the local node.