public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node
Date: Fri, 6 May 2022 10:11:27 +0200	[thread overview]
Message-ID: <d94290e7-3807-db7b-326c-9e07e0669fb4@proxmox.com> (raw)
In-Reply-To: <34ee9614-74dd-8556-3c53-84efdbeab553@proxmox.com>

On 06.05.2022 10:00, Thomas Lamprecht wrote:
> Am 5/5/22 um 16:27 schrieb Matthias Heiserer:

>>   www/manager6/ceph/CephInstallWizard.js | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
>> index 59458b0d..ebdc7f1d 100644
>> --- a/www/manager6/ceph/CephInstallWizard.js
>> +++ b/www/manager6/ceph/CephInstallWizard.js
>> @@ -403,6 +403,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
>>   		    name: 'mon-node',
>>   		    selectCurNode: true,
>>   		    allowBlank: false,
>> +		    preferredValue: Proxmox.NodeName,
> 
> That is always the local node one is connected through the web interface.
> So, what if I'm connected through Node A but currently installing/initializing ceph on Node B?
> Should this rather be the node currently selected in the resource tree?

Well, yes, the node selector already does that. This patch only changes 
the behavior when installing ceph after selecting the datacenter in the 
GUI. In which case ceph is installed on the local node.




      reply	other threads:[~2022-05-06  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 14:27 Matthias Heiserer
2022-05-06  8:00 ` Thomas Lamprecht
2022-05-06  8:11   ` Matthias Heiserer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d94290e7-3807-db7b-326c-9e07e0669fb4@proxmox.com \
    --to=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal